Logger abstraction added by Reversean · Pull Request #159 · codex-team/hawk.javascript

Reversean · 2026-02-12T18:33:53Z

Related #151

Added env-agnostic Logger abstraction.

Also added global singleton loggerInstance which could be set via setLogger and used via log methods.

Also added browser-specific logger factory-method createBrowserLogger which may be used as Logger.

Copilot

Pull request overview

This PR introduces an environment-agnostic logger abstraction to support the architectural refactoring described in issue #151. The implementation separates core logging functionality from browser-specific implementation details, setting the foundation for a cleaner package structure that will enable code reuse across different JavaScript environments (Node.js, Nuxt, etc.).

Changes:

Added core logger abstraction (Logger interface, LogType, setLogger(), log()) to @hawk.so/core
Migrated browser-specific logger from utils/log.ts to logger/logger.ts as a factory function
Updated all imports across the codebase to use the new logger from @hawk.so/core

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/core/src/logger/logger.ts	Defines environment-agnostic Logger interface, LogType, and global logger singleton with setLogger/log functions
packages/core/src/index.ts	Exports Logger, LogType, setLogger, and log from core package
packages/javascript/src/logger/logger.ts	Browser-specific logger implementation as factory function createBrowserLogger
packages/javascript/src/catcher.ts	Initializes logger in constructor; minor formatting improvements to object destructuring
packages/javascript/src/utils/log.ts	Removed old browser-specific logger implementation
packages/javascript/src/utils/validation.ts	Updated to import log from @hawk.so/core
packages/javascript/src/utils/event.ts	Updated to import log from @hawk.so/core
packages/javascript/src/modules/socket.ts	Updated to import log from @hawk.so/core
packages/javascript/src/modules/fetchTimer.ts	Updated to import log from @hawk.so/core
packages/javascript/src/addons/breadcrumbs.ts	Updated to import log from @hawk.so/core
packages/javascript/tests/logger/logger.test.ts	Comprehensive tests for browser logger implementation
packages/javascript/tests/breadcrumbs.test.ts	Updated to spy on core log function instead of console.warn

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T18:28:08Z

packages/javascript/src/catcher.ts

    try {
      const decodedIntegrationToken: DecodedIntegrationToken = JSON.parse(atob(this.token));
-      const {integrationId} = decodedIntegrationToken;
+      const { integrationId } = decodedIntegrationToken;


This formatting change (adding spaces inside object destructuring) appears to be unrelated to the logger abstraction changes and is a minor style adjustment. While it improves consistency with modern JavaScript style conventions, it would be better to keep such formatting changes separate from functional changes in a PR, or apply them consistently throughout the file if they're part of a deliberate style update.

Suggested change

const { integrationId } = decodedIntegrationToken;

const {integrationId} = decodedIntegrationToken;

Copilot · 2026-02-17T18:28:09Z

packages/javascript/src/catcher.ts

      return user;
    }
-    const newUser: AffectedUser = {id: id()};
+    const newUser: AffectedUser = { id: id() };


This formatting change (adding spaces inside object destructuring) appears to be unrelated to the logger abstraction changes and is a minor style adjustment. While it improves consistency with modern JavaScript style conventions, it would be better to keep such formatting changes separate from functional changes in a PR, or apply them consistently throughout the file if they're part of a deliberate style update.

Suggested change

const newUser: AffectedUser = { id: id() };

const newUser: AffectedUser = {id: id()};

Copilot · 2026-02-17T18:28:09Z

packages/javascript/src/catcher.ts

   */
  private getAddons(error: Error | string): HawkJavaScriptEvent['addons'] {
-    const {innerWidth, innerHeight} = window;
+    const { innerWidth, innerHeight } = window;


This formatting change (adding spaces inside object destructuring) appears to be unrelated to the logger abstraction changes and is a minor style adjustment. While it improves consistency with modern JavaScript style conventions, it would be better to keep such formatting changes separate from functional changes in a PR, or apply them consistently throughout the file if they're part of a deliberate style update.

Copilot · 2026-02-17T18:28:09Z

packages/core/src/logger/logger.ts

+export function setLogger(logger: Logger): void {
+  loggerInstance = logger;
+}
+
+/**
+ * Logs a message using the registered logger implementation.
+ *
+ * If no logger has been registered via {@link setLogger}, this is a no-op.
+ *
+ * @param msg - Message to log.
+ * @param type - Log level (default: 'log').
+ * @param args - Additional arguments to log.
+ */
+export function log(msg: string, type?: LogType, args?: unknown): void {
+  if (loggerInstance) {
+    loggerInstance(msg, type, args);
+  }
+}


The core logger abstraction (setLogger and log functions in @hawk.so/core) lacks test coverage. While the browser-specific implementation (createBrowserLogger) has comprehensive tests, the core abstraction functions are not tested. Consider adding tests to verify that: 1) log is a no-op when no logger is set, 2) setLogger correctly registers a logger, 3) log correctly delegates to the registered logger, and 4) the logger can be replaced by calling setLogger again.

Copilot · 2026-02-17T18:28:09Z

packages/javascript/src/catcher.ts

   * @param {HawkInitialSettings|string} settings - If settings is a string, it means an Integration Token
   */
  constructor(settings: HawkInitialSettings | string) {
+    setLogger(createBrowserLogger(VERSION));


The logger is set on every Catcher instantiation, which means creating multiple Catcher instances will repeatedly call setLogger with the same logger implementation. While this doesn't cause functional issues (since VERSION is constant), it's wasteful. Consider checking if a logger is already set before creating and setting a new one, or set it once at module initialization time. For example: if (!isLoggerSet()) { setLogger(createBrowserLogger(VERSION)); } where isLoggerSet() is a new function exported from @hawk.so/core.

Copilot · 2026-02-17T18:28:10Z

packages/javascript/src/logger/logger.ts

+ *
+ * @example
+ * ```TypeScript
+ * import { createBrowserLogger } from '@hawk.so/browser';


The import path in the documentation example is incorrect. The function is exported from '@hawk.so/javascript', not '@hawk.so/browser'. This could confuse users trying to use the logger. The example should use the correct package name that matches where this code actually lives.

Suggested change

* import { createBrowserLogger } from '@hawk.so/browser';

* import { createBrowserLogger } from '@hawk.so/javascript';

Copilot · 2026-02-17T18:28:10Z

packages/javascript/src/logger/logger.ts

+    const editorLabelStyle = `line-height: 1em;
+            color: #fff;
+            display: inline-block;
+            line-height: 1em;


The CSS style string contains duplicate 'line-height: 1em;' properties on lines 33 and 36. While this doesn't cause an error, the second declaration will override the first, making the first one redundant. Consider removing one of the duplicate declarations to clean up the code.

Suggested change

line-height: 1em;

Reversean changed the title ~~refactor(core): UserManager abstraction added~~ UserManager abstraction added Feb 12, 2026

Reversean changed the title ~~UserManager abstraction added~~ Logger abstraction added Feb 12, 2026

Reversean marked this pull request as draft February 12, 2026 18:36

Reversean force-pushed the refactor/catcher-logger branch from 6d66554 to 0ca5710 Compare February 12, 2026 18:49

Reversean force-pushed the refactor/user-manager branch 2 times, most recently from 37eecbd to 70760fd Compare February 12, 2026 19:44

Reversean force-pushed the refactor/catcher-logger branch from 0ca5710 to 4ad2b5f Compare February 12, 2026 19:45

Reversean force-pushed the refactor/user-manager branch 5 times, most recently from a0132ff to 9a60f23 Compare February 16, 2026 22:22

Reversean force-pushed the refactor/catcher-logger branch from 4ad2b5f to 9c05fec Compare February 16, 2026 22:23

Reversean force-pushed the refactor/user-manager branch from 9a60f23 to eacefe1 Compare February 16, 2026 22:27

Reversean force-pushed the refactor/catcher-logger branch from 9c05fec to 53f65cb Compare February 16, 2026 22:30

Reversean marked this pull request as ready for review February 16, 2026 22:31

Reversean force-pushed the refactor/catcher-logger branch from 53f65cb to 99bbc51 Compare February 16, 2026 22:41

Reversean force-pushed the refactor/user-manager branch from eacefe1 to 7d5e8e4 Compare February 17, 2026 13:40

Reversean force-pushed the refactor/catcher-logger branch 2 times, most recently from 8b30a3c to 202e102 Compare February 17, 2026 13:51

refactor(core): Logger abstraction added

202e102

neSpecc approved these changes Feb 17, 2026

View reviewed changes

neSpecc requested a review from Copilot February 17, 2026 18:20

Copilot started reviewing on behalf of neSpecc February 17, 2026 18:21 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logger abstraction added#159

Logger abstraction added#159
Reversean wants to merge 1 commit intorefactor/user-managerfrom
refactor/catcher-logger

Reversean commented Feb 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const { integrationId } = decodedIntegrationToken;
	const {integrationId} = decodedIntegrationToken;

	const newUser: AffectedUser = { id: id() };
	const newUser: AffectedUser = {id: id()};

	* import { createBrowserLogger } from '@hawk.so/browser';
	* import { createBrowserLogger } from '@hawk.so/javascript';

Conversation

Reversean commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reversean commented Feb 12, 2026 •

edited

Loading